Commit cc0fb281 authored by Florian Fittkau's avatar Florian Fittkau

done some TODOs

parent e21b6b0c
...@@ -60,8 +60,8 @@ public class ActiveMQProbe { ...@@ -60,8 +60,8 @@ public class ActiveMQProbe {
final String destinationName = destination != null ? destination final String destinationName = destination != null ? destination
.getQualifiedName() .getQualifiedName()
: DistributedMonitoringRecordWriter.UNKNOWN_DESTINATION; : DistributedMonitoringRecordWriter.UNKNOWN_DESTINATION;
DistributedMonitoringRecordWriter.writeBeforeSentRecord(traceId, orderId, DistributedMonitoringRecordWriter.writeBeforeSentRecord(traceId, orderId,
destinationName); destinationName);
} }
} catch (final JMSException e) { } catch (final JMSException e) {
} finally { } finally {
...@@ -118,9 +118,9 @@ public class ActiveMQProbe { ...@@ -118,9 +118,9 @@ public class ActiveMQProbe {
private void unknownRecordReceived(final ActiveMQMessage messageAMQ, final long ownTraceId, private void unknownRecordReceived(final ActiveMQMessage messageAMQ, final long ownTraceId,
final int ownOrderId) { final int ownOrderId) {
DistributedMonitoringRecordWriter.writeBeforeUnknownReceivedRecord(ownTraceId, DistributedMonitoringRecordWriter.writeBeforeUnknownReceivedRecord(ownTraceId, ownOrderId,
ownOrderId, DistributedMonitoringRecordWriter.UNKNOWN_SENDER, messageAMQ DistributedMonitoringRecordWriter.UNKNOWN_SENDER, messageAMQ.getDestination()
.getDestination().toString()); .toString());
} }
@Around("call(void org.apache.activemq.broker.region.Queue.sendMessage(org.apache.activemq.command.Message))") @Around("call(void org.apache.activemq.broker.region.Queue.sendMessage(org.apache.activemq.command.Message))")
...@@ -162,12 +162,11 @@ public class ActiveMQProbe { ...@@ -162,12 +162,11 @@ public class ActiveMQProbe {
final long traceId = messageAMQ.getLongProperty(TRACE_ID_HEADER_ATTRIBUTE); final long traceId = messageAMQ.getLongProperty(TRACE_ID_HEADER_ATTRIBUTE);
final int orderId = messageAMQ.getIntProperty(ORDER_ID_HEADER_ATTRIBUTE); final int orderId = messageAMQ.getIntProperty(ORDER_ID_HEADER_ATTRIBUTE);
DistributedMonitoringRecordWriter.writeBeforeReceivedRecord(ownTraceId, DistributedMonitoringRecordWriter.writeBeforeReceivedRecord(ownTraceId, ownOrderId,
ownOrderId, traceId, orderId); traceId, orderId);
} else { } else {
// Message has no monitoring information // Message has no monitoring information
// TODO sender information
DistributedMonitoringRecordWriter.writeBeforeUnknownReceivedRecord(ownTraceId, DistributedMonitoringRecordWriter.writeBeforeUnknownReceivedRecord(ownTraceId,
ownOrderId, "", messageAMQ.getDestination().toString()); ownOrderId, "", messageAMQ.getDestination().toString());
} }
...@@ -182,8 +181,8 @@ public class ActiveMQProbe { ...@@ -182,8 +181,8 @@ public class ActiveMQProbe {
} }
} catch (final IOException e) { } catch (final IOException e) {
} }
DistributedMonitoringRecordWriter.writeBeforeSentRecord(ownTraceId, ownOrderId, DistributedMonitoringRecordWriter.writeBeforeSentRecord(ownTraceId, ownOrderId, messageAMQ
messageAMQ.getDestination().toString()); .getDestination().toString());
} }
@Around("execution(boolean org.apache.activemq.broker.region.PrefetchSubscription.dispatch(..))") @Around("execution(boolean org.apache.activemq.broker.region.PrefetchSubscription.dispatch(..))")
......
...@@ -84,7 +84,6 @@ public class AbstractAspectTest { ...@@ -84,7 +84,6 @@ public class AbstractAspectTest {
@Override @Override
public void monitoredConstructor() { public void monitoredConstructor() {
// TODO Auto-generated method stub
} }
} }
...@@ -100,7 +99,6 @@ public class AbstractAspectTest { ...@@ -100,7 +99,6 @@ public class AbstractAspectTest {
@Override @Override
public void monitoredConstructor() { public void monitoredConstructor() {
// TODO Auto-generated method stub
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment